Skip to content

Hometask/4#28

Open
shtbik wants to merge 3 commits intoromabelka:masterfrom
shtbik:hometask/4
Open

Hometask/4#28
shtbik wants to merge 3 commits intoromabelka:masterfrom
shtbik:hometask/4

Conversation

@shtbik
Copy link

@shtbik shtbik commented May 30, 2018

Сделал первую часть домашнего задания.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В результате тут ничего не происходит?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, эту часть не доделал

const { eventUid, personUid } = action.payload
const eventsRef = firebase.database().ref(`people/${personUid}/events`)
const events = yield select(personEventsSelector, { uid: personUid })
const nextPersonEvents = [...new Set([...events, eventUid])]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Возьми просто Immutable Set

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Согласен

@shtbik shtbik changed the title hometast/4 hometask/4 Jun 1, 2018
@shtbik shtbik changed the title hometask/4 Hometask/4 Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments